-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: run e2e tests in github actions #11
Conversation
Warning Rate Limit Exceeded@johnletey has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 23 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe updates focus on enhancing CI/CD processes by integrating end-to-end (E2E) and unit testing within GitHub Actions. A Dockerfile and Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
ed0acff
to
7892b89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boojamya Let's chat in our sync today about this. I was under the impression that we could simply use the heighliner-build-action
, but also like the approach of a simple Dockerfile.
Either way, could we get newlines added to all end of files? See one of my comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Out of diff range and nitpick comments (2)
.github/workflows/e2e-tests.bak (2)
1-1
: Ensure the workflow name is descriptive and specific.Consider renaming the workflow to something more descriptive, such as "Docker-based End-to-End Tests", to clearly distinguish its purpose in the CI/CD pipeline.
22-30
: Optimize Docker image build process.Consider optimizing the Docker image build process by specifying more efficient caching mechanisms or exploring multi-stage builds to reduce the build time and size of the Docker image.
57e92ca
to
e7f9acd
Compare
Co-authored-by: John Letey <john@nobleassets.xyz> Signed-off-by: Dan Kanefsky <56059752+boojamya@users.noreply.github.com>
After a lot of testing, the action is working! It required the SL team cutting a new release of heighliner as the old release was not compatible with go 1.22. For context, the action automatically uses the latest release of heighliner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/e2e-tests.yaml (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/e2e-tests.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/e2e-tests.yaml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/e2e-tests.yaml
closes #6
Summary by CodeRabbit
New Features
chains.yaml
.Bug Fixes
Chores