Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunderbird: add message filters option #6558

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

347Online
Copy link

@347Online 347Online commented Mar 1, 2025

Add option to declare account-specific message filters.

Description

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.
    Neither of these are working for me currently, even against master, happy to re-run if there's something I'm missing

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@d-dervishi @hakan-demirli @ethorsoe @javaes

@github-actions github-actions bot added the mail label Mar 1, 2025
@347Online
Copy link
Author

This would not have been possible without this PR as a reference

That said, I think I've made some improvements giving the option a fleshed out type rather than a freeform attrset.

I also went a different direction on the example/test rule.

@347Online 347Online force-pushed the master branch 4 times, most recently from ee33fe0 to b3325ae Compare March 1, 2025 10:36
@347Online 347Online force-pushed the master branch 2 times, most recently from 8eb8041 to 55d7cfc Compare March 1, 2025 18:29
@347Online 347Online requested a review from khaneliman March 1, 2025 19:31
@khaneliman
Copy link
Collaborator

This would not have been possible without this PR as a reference

That said, I think I've made some improvements giving the option a fleshed out type rather than a freeform attrset.

I would always prefer a submodule with freeform support and use defined known options as a guide, though. Allows us to not restrict user's if we haven't configured something explicitly and reduce maintenance burden.

@347Online
Copy link
Author

347Online commented Mar 2, 2025

You make a good point. Would extraConfig be sufficient here?

Add option to declare account-specific message filters.
@347Online
Copy link
Author

347Online commented Mar 2, 2025

@khaneliman I went ahead and added a text option to provide a completely custom one, or extraConfig to expand on the existing options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants