Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distrobox: add module #6528

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aguirre-matteo
Copy link

@aguirre-matteo aguirre-matteo commented Feb 25, 2025

Description

Added programs/distrobox.nix module. It provides the option "programs.distrobox.containers", which makes it possible to declare a list of containers to be created. Since building those containers is not possible at build time (because none container backend is available at that time), I also added the options "enableBashIntegration" and "enableZshIntegration", which adds some code to .bashrc and .zshrc respectively that looks for changes in the file "containers.ini" and prompts the user to build the containers.

Support for other shells, like Fish and Nushell, will be added soon.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@aguirre-matteo aguirre-matteo marked this pull request as draft March 1, 2025 14:36
@aguirre-matteo aguirre-matteo force-pushed the module-distrobox branch 3 times, most recently from 2c4a2e4 to a22407c Compare March 1, 2025 15:48
@aguirre-matteo
Copy link
Author

Support for Fish and Nushell has been added. So the pull request is ready to be merged.

@aguirre-matteo aguirre-matteo marked this pull request as ready for review March 2, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant