Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show help for CliConfigs #55

Merged
merged 7 commits into from
Sep 3, 2024
Merged

show help for CliConfigs #55

merged 7 commits into from
Sep 3, 2024

Conversation

itsspriyansh
Copy link
Contributor

@itsspriyansh itsspriyansh commented Jul 25, 2024 •
edited
Loading

Description

This PR adds support for showing usage instructions for configs. There are two types of configs handled here,

# corresponding to subcommands 
disconnect --deviceId <device_id>

# corresponding to flags
connect --emulator --avd <avd_name>

image

@itsspriyansh itsspriyansh mentioned this pull request Jul 25, 2024
Closed
@itsspriyansh itsspriyansh changed the title show help for valued flags show help for flags Jul 29, 2024
@itsspriyansh itsspriyansh mentioned this pull request Aug 18, 2024
Merged
@itsspriyansh
Copy link
Contributor Author

@garg3133 PR updated.

@itsspriyansh itsspriyansh changed the title show help for flags show help for cliConfigs Aug 21, 2024
@itsspriyansh itsspriyansh changed the title show help for cliConfigs show help for CliConfigs Aug 21, 2024
garg3133
garg3133 approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@garg3133 garg3133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant work on this, thanks!

@garg3133 garg3133 merged commit 51c3e20 into nightwatchjs:main Sep 3, 2024
2 checks passed
@itsspriyansh
Copy link
Contributor Author

Brilliant work on this, thanks!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garg3133 garg3133 garg3133 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsspriyansh @garg3133