Fix issue where type under organizeDeclarations line count threshold would ignore swiftformat:sort
directive
#1976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sorting a type body with both
sortDeclarations
andorganizeDeclarations
are enabled, thesortDeclarations
rule defers to theorganizeDeclararions
rule, which has a specialized sorting implementation.However, the
orgganizeDeclarations
rule won't apply to any type below the configurable line count threshold. Since bothsortDeclarations
andorganizeDeclarations
are disabled in this case, anyswiftformat:sort
would be ignored.Now, the
sortDeclarations
rule checks whether the type is under theorganizeDeclarations
threshold, and if so will now sort the type body.