Update conditionalAssignment rule to support more complex lvalues #1647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
conditionalAssignment
rule to support more complex lvalues. Previously it required that the value being assigned was just a simple identifier likefoo =
. Now it supports more complex lvalues likefoo?.bar =
,foo["bar"] =
, etc.For example, this sample code was left as-is before:
Now it is updated as expected:
I also added a new
--condassignment after-property
to let consumers disable the new functionality added in #1643. After running the updated rule on our codebase, I found too many of the changes weird and unusual. On the other hand I found the previous behavior (only applying the new syntax after a new property declaration) reasonable almost all of the time.