Skip to content
This repository has been archived by the owner on Jun 14, 2018. It is now read-only.

Commit

Permalink
fix(table): update tests to address jQuery
Browse files Browse the repository at this point in the history 
Updated tests to address issue where jQuery was being loaded before Angular and thus, Angular was using jQuery & not jqLite, causing false positives.

Closes #123.
  • Loading branch information
@andrewconnell
andrewconnell committed Feb 1, 2016
1 parent 5580c99 commit eca2abf
Showing 1 changed file with 21 additions and 1 deletion.
22 changes: 21 additions & 1 deletion src/components/table/tableDirective.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import * as ng from 'angular';

describe('tableDirective: <uif-table />', () => {
let element: ng.IAugmentedJQuery;
let element: JQuery;
let scope: any;

beforeEach(() => {
Expand Down Expand Up @@ -113,6 +113,7 @@ describe('tableDirective: <uif-table />', () => {
element = ng.element('<uif-table><uif-table-row><uif-table-header></uif-table-header>\
<uif-table-header uif-order-by="fileName"></uif-table-header></uif-table-row></uif-table>');
$compile(element)(scope);
element = jQuery(element[0]);
scope.$digest();

let headerCells: JQuery = element.children().eq(0).children();
Expand All @@ -139,6 +140,7 @@ describe('tableDirective: <uif-table />', () => {
element = ng.element('<uif-table><uif-table-row><uif-table-header></uif-table-header>\
<uif-table-header uif-order-by="fileName"></uif-table-header></uif-table-row></uif-table>');
$compile(element)(scope);
element = jQuery(element[0]);
scope.$digest();

let fileNameHeader: JQuery = element.children().eq(0).children().eq(1);
Expand All @@ -159,6 +161,7 @@ describe('tableDirective: <uif-table />', () => {
element = ng.element('<uif-table><uif-table-row><uif-table-header>ID</uif-table-header>\
<uif-table-header uif-order-by="fileName">File name</uif-table-header></uif-table-row></uif-table>');
$compile(element)(scope);
element = jQuery(element[0]);
scope.$digest();

let fileNameHeader: JQuery = element.children().eq(0).children().eq(1);
Expand All @@ -173,6 +176,7 @@ describe('tableDirective: <uif-table />', () => {
element = ng.element('<uif-table><uif-table-row><uif-table-header></uif-table-header>\
<uif-table-header uif-order-by="fileName"></uif-table-header></uif-table-row></uif-table>');
$compile(element)(scope);
element = jQuery(element[0]);
scope.$digest();

let fileNameHeader: JQuery = element.children().eq(0).children().eq(1);
Expand All @@ -185,6 +189,7 @@ describe('tableDirective: <uif-table />', () => {
element = ng.element('<uif-table><uif-table-row><uif-table-header></uif-table-header>\
<uif-table-header uif-order-by="fileName"></uif-table-header></uif-table-row></uif-table>');
$compile(element)(scope);
element = jQuery(element[0]);
scope.$digest();

let fileNameHeader: JQuery = element.children().eq(0).children().eq(1);
Expand All @@ -201,6 +206,7 @@ describe('tableDirective: <uif-table />', () => {
element = ng.element('<uif-table><uif-table-row><uif-table-header uif-order-by="id">ID</uif-table-header>\
<uif-table-header uif-order-by="fileName">File name</uif-table-header></uif-table-row></uif-table>');
$compile(element)(scope);
element = jQuery(element[0]);
scope.$digest();

let idHeader: JQuery = element.children().eq(0).children().eq(0);
Expand All @@ -216,6 +222,7 @@ describe('tableDirective: <uif-table />', () => {
element = ng.element('<uif-table><uif-table-row><uif-table-header uif-order-by="id"></uif-table-header>\
<uif-table-header uif-order-by="fileName"></uif-table-header></uif-table-row></uif-table>');
$compile(element)(scope);
element = jQuery(element[0]);
scope.$digest();

let idHeader: JQuery = element.children().eq(0).children().eq(0);
Expand All @@ -231,6 +238,7 @@ describe('tableDirective: <uif-table />', () => {
element = ng.element('<uif-table><uif-table-row><uif-table-header></uif-table-header>\
<uif-table-header uif-order-by="fileName"></uif-table-header></uif-table-row></uif-table>');
$compile(element)(scope);
element = jQuery(element[0]);
scope.$digest();

let firstHeader: JQuery = element.children().eq(0).children().eq(0);
Expand Down Expand Up @@ -267,6 +275,7 @@ describe('tableDirective: <uif-table />', () => {
'<uif-table-row></uif-table-row>' +
'<uif-table-row ng-repeat="n in [1, 2, 3]" uif-item="n"></uif-table-row></uif-table>');
$compile(element)(scope);
element = jQuery(element[0]);
scope.$digest();

expect(scope.rowSelectMode).toEqual('single');
Expand All @@ -293,6 +302,7 @@ describe('tableDirective: <uif-table />', () => {
'<uif-table-row></uif-table-row>' +
'<uif-table-row ng-repeat="n in [1, 2, 3]" uif-item="n"></uif-table-row></uif-table>');
$compile(element)(scope);
element = jQuery(element[0]);
scope.$digest();

expect(scope.rowSelectMode).toEqual('multiple');
Expand Down Expand Up @@ -329,6 +339,7 @@ describe('tableDirective: <uif-table />', () => {
'<uif-table-row></uif-table-row>' +
'<uif-table-row ng-repeat="n in [1, 2, 3]" uif-item="n"></uif-table-row></uif-table>');
$compile(element)(scope);
element = jQuery(element[0]);
scope.$digest();

let headerRow: JQuery = element.children().eq(0);
Expand Down Expand Up @@ -363,6 +374,7 @@ describe('tableDirective: <uif-table />', () => {
'<uif-table-row></uif-table-row>' +
'<uif-table-row ng-repeat="n in [1, 2, 3]" uif-item="n"></uif-table-row></uif-table>');
$compile(element)(scope);
element = jQuery(element[0]);
scope.$digest();

let tableRow: JQuery = element.children().eq(1);
Expand All @@ -377,6 +389,7 @@ describe('tableDirective: <uif-table />', () => {
'<uif-table-row><uif-table-row-select></uif-table-row-select></uif-table-row>' +
'<uif-table-row ng-repeat="n in [1, 2, 3]" uif-item="n"><uif-table-row-select></uif-table-row-select></uif-table-row></uif-table>');
$compile(element)(scope);
element = jQuery(element[0]);
scope.$digest();

let tableRowSelect: JQuery = element.children().eq(0).children().eq(0);
Expand Down Expand Up @@ -411,6 +424,7 @@ describe('tableDirective: <uif-table />', () => {
'<uif-table-row></uif-table-row>' +
'<uif-table-row ng-repeat="n in [1, 2, 3]" uif-item="n"></uif-table-row></uif-table>');
$compile(element)(scope);
element = jQuery(element[0]);
scope.$digest();

let firstDataRow: JQuery = element.children().eq(1);
Expand All @@ -431,6 +445,7 @@ describe('tableDirective: <uif-table />', () => {
'<uif-table-row></uif-table-row>' +
'<uif-table-row ng-repeat="n in [1, 2, 3]" uif-item="n"></uif-table-row></uif-table>');
$compile(element)(scope);
element = jQuery(element[0]);
scope.$digest();

let firstDataRow: JQuery = element.children().eq(1);
Expand All @@ -447,6 +462,7 @@ describe('tableDirective: <uif-table />', () => {
'<uif-table-row><uif-table-row-select></uif-table-row-select></uif-table-row>' +
'<uif-table-row ng-repeat="n in [1, 2, 3]" uif-item="n"><uif-table-row-select></uif-table-row-select></uif-table-row></uif-table>');
$compile(element)(scope);
element = jQuery(element[0]);
scope.$digest();

let tableRowSelectInHeader: JQuery = element.children().eq(0).children().eq(0);
Expand Down Expand Up @@ -481,6 +497,7 @@ describe('tableDirective: <uif-table />', () => {
'<uif-table-row></uif-table-row>' +
'<uif-table-row ng-repeat="n in [1, 2, 3]" uif-item="n"></uif-table-row></uif-table>');
$compile(element)(scope);
element = jQuery(element[0]);
scope.$digest();

let tableRow: JQuery = element.children().eq(1);
Expand All @@ -496,6 +513,7 @@ describe('tableDirective: <uif-table />', () => {
'<uif-table-row></uif-table-row>' +
'<uif-table-row ng-repeat="n in [1, 2, 3]" uif-item="n"></uif-table-row></uif-table>');
$compile(element)(scope);
element = jQuery(element[0]);
scope.$digest();

let tableRow: JQuery = element.children().eq(1);
Expand All @@ -512,6 +530,7 @@ describe('tableDirective: <uif-table />', () => {
'<uif-table-row><uif-table-row-select></uif-table-row-select></uif-table-row>' +
'<uif-table-row ng-repeat="n in [1, 2, 3]" uif-item="n"><uif-table-row-select></uif-table-row-select></uif-table-row></uif-table>');
$compile(element)(scope);
element = jQuery(element[0]);
scope.$digest();

let tableRowSelect: JQuery = element.children().eq(0).children().eq(0);
Expand All @@ -534,6 +553,7 @@ describe('tableDirective: <uif-table />', () => {
'<uif-table-row><uif-table-row-select></uif-table-row-select></uif-table-row>' +
'<uif-table-row ng-repeat="n in [1, 2, 3]" uif-item="n"><uif-table-row-select></uif-table-row-select></uif-table-row></uif-table>');
$compile(element)(scope);
element = jQuery(element[0]);
scope.$digest();

// select all rows
Expand Down

0 comments on commit eca2abf

Please sign in to comment.