curate format-dates: Mention that 'XX' can be used in --expected-date-formats
#1718
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
joverlee521
approved these changes
Jan 14, 2025
genehack
approved these changes
Jan 14, 2025
victorlin
force-pushed
the
victorlin/ExtendOverwriteDefault-everwhere
branch
from
49568ad to
28e6e8c
Compare
Base automatically changed from
victorlin/ExtendOverwriteDefault-everwhere
to
master
January 14, 2025 18:48
This is worth calling out because it would be reasonable for a user to assume that Augur's support XX is automatically applied to dates like %Y-%m-%d. The added explicit mention + existing list of builtin formats including XX explicitly should help avoid that assumption. Co-authored-by: Thomas Sibley <tsibley@fredhutch.org>
victorlin
force-pushed
the
victorlin/update-expected-date-formats-help
branch
from
9c8635b to
62299d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This is worth calling out because it would be reasonable for a user to assume that Augur's support XX is automatically applied to dates like %Y-%m-%d. The added explicit mention + existing list of builtin formats including XX explicitly should help avoid that assumption.
Related issue(s)
#1709 (comment)
Checklist
ExtendOverwriteDefaultfor all multi-value options #1709