Feat: add proofread provider #169
Conversation
janepie
force-pushed
the
feat/add-proofread-provider
branch
4 times, most recently
from
496b9eb to
796ac57
Compare
|
Do I guess correctly that psalm will run as soon as /~https://github.com/nextcloud-deps/ocp will be updated? |
janepie
force-pushed
the
feat/add-proofread-provider
branch
from
796ac57 to
16597e0
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
janepie
force-pushed
the
feat/add-proofread-provider
branch
from
16597e0 to
2da1407
Compare
lib/AppInfo/Application.php
Outdated
| @@ -105,6 +106,9 @@ public function register(IRegistrationContext $context): void { | |||
| if (class_exists('OCP\\TaskProcessing\\TaskTypes\\TextToTextChatWithTools')) { | |||
| $context->registerTaskProcessingProvider(\OCA\OpenAi\TaskProcessing\TextToTextChatWithToolsProvider::class); | |||
| } | |||
| if (class_exists('OCP\\TaskProcessing\\TaskTypes\\TextToTextProofread')) { | |||
| $context->registerTaskProcessingProvider(ProofreadProvider::class); | |||
There was a problem hiding this comment.
I think you will need to put the full class path in this line, otherwise PHP will try to load the class when loading Application.php and then will try to load OCP\TaskProcessing\TaskTypes\TextToTextProofread which will fail and the whole app will fail. I'm not sure if this is still the case, but I think that was a problem I ran into a few times.
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
janepie
force-pushed
the
feat/add-proofread-provider
branch
from
2da1407 to
cc8e936
Compare
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
feat/add-proofread-provider
branch
from
944cef9 to
d554856
Compare
There was a problem hiding this comment.
Works fine!
I tried to change the system prompt to force the llm to write correction recommendations in the same language as the submitted text but i couldn't get it to work.
I hope you don't mind, I made a small change to use the system prompt param of OpenAiAPIService::createChatCompletion.
Mh, that's not ideal, we should fix this at some point |
No description provided.