Improve loading routine of editors #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This assures that the textarea will always have the correct size, even when used in the appsidebar. Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Codecov Report
@@ Coverage Diff @@
## master #2528 +/- ##
============================================
+ Coverage 30.00% 30.04% +0.04%
- Complexity 103 116 +13
============================================
Files 149 153 +4
Lines 5356 5451 +95
Branches 802 803 +1
============================================
+ Hits 1607 1638 +31
- Misses 3749 3813 +64
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
georgehrke
force-pushed
the
bugfix/2459/sidebar_loading_error_handling
branch
from
d431728 to
b16f5b7
Compare
georgehrke
added
3. to review
|
We should add more detailed error messages later, like:
But that's something for a follow up PR :) |
Merged
raimund-schluessler
approved these changes
Sep 1, 2020
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
georgehrke
force-pushed
the
bugfix/2459/sidebar_loading_error_handling
branch
from
b16f5b7 to
a77df0c
Compare
delete-merged-branch
bot
deleted the
bugfix/2459/sidebar_loading_error_handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2459
fixes #2187
also removes the ugly v-if/v-show hack.