Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NcDialog): Allow to catch reset event #6006

Merged
merged 1 commit into from
Feb 28, 2025
Merged

feat(NcDialog): Allow to catch reset event #6006

merged 1 commit into from
Feb 28, 2025
+155 −11

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 21, 2024 •
edited
Loading

☑️ Resolves

Sometimes it is useful to also have a reset button, we already support the native type reset so this allows to catch the reset event.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews feature: dialog Related to the dialog component labels Aug 21, 2024
@susnux susnux added this to the 8.18.0 milestone Aug 21, 2024
@susnux susnux force-pushed the feat/ncdialog-reset branch from f43e99d to 885e7d7 Compare August 21, 2024 22:34
@Antreesy Antreesy modified the milestones: 8.18.0, 8.19.0 Sep 12, 2024
@susnux susnux modified the milestones: 8.19.0, 8.20.0 Sep 17, 2024
@Antreesy Antreesy modified the milestones: 8.20.0, 8.21.0 Nov 11, 2024
@Antreesy Antreesy modified the milestones: 8.21.0, 8.22.0 Nov 21, 2024
@hamza221 hamza221 modified the milestones: 8.22.0, 8.23.0 Dec 23, 2024
@Antreesy Antreesy modified the milestones: 8.23.0, 8.24.0 Feb 13, 2025
@susnux susnux requested review from ShGKme, st3iny and Antreesy February 28, 2025 13:13
@susnux susnux marked this pull request as ready for review February 28, 2025 13:14
@susnux susnux force-pushed the feat/ncdialog-reset branch from 885e7d7 to 38f52bb Compare February 28, 2025 13:57
ShGKme
ShGKme approved these changes Feb 28, 2025
View reviewed changes
@susnux susnux force-pushed the feat/ncdialog-reset branch from fc386ff to 90139f0 Compare February 28, 2025 15:28
@susnux
Copy link
Contributor Author

susnux commented Feb 28, 2025

/backport to next

@susnux
Copy link
Contributor Author

susnux commented Feb 28, 2025

Added tests

@susnux
feat(NcDialog): Allow to catch reset event
1e64c30 
Sometimes it is useful to also have a reset button,
we already support the native type `reset` so this allows to catch the `reset` event.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feat/ncdialog-reset branch from 90139f0 to 1e64c30 Compare February 28, 2025 21:41
@susnux susnux merged commit 3779b88 into master Feb 28, 2025
23 checks passed
@susnux susnux deleted the feat/ncdialog-reset branch February 28, 2025 22:36
@backportbot backportbot bot mentioned this pull request Feb 28, 2025
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@Antreesy Antreesy Antreesy approved these changes

@st3iny st3iny Awaiting requested review from st3iny

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request feature: dialog Related to the dialog component
Projects
None yet
Milestone
8.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @ShGKme @Antreesy @hamza221