-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make package ESM by default #4957
Conversation
79127b4
to
82810aa
Compare
Basically this works and simplifies the code base, but it does not fix the Typescript issue |
Do we want this for v8 or should I change the target branch to |
I think this is fine for v8. It should not affect the distributive and works fine on Server. Probably, we should test on more apps before just in case, e.g., Talk. |
Talk works including calls |
So, do we want to add this to the next minor release? |
Switching package types is a breaking change, even if that does not break on our ecosystem :) |
82810aa
to
d56c508
Compare
What does this change break? It doesn't affect end users of the package. So it changes development part, but doesn't change the distributive. |
The module resolution changes. |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
d56c508
to
572a73d
Compare
Merged into Next for reasons mentioned by @skjnldsv |
☑️ Resolves
Supersedes chore(deps-dev): Bump typescript from 5.2.2 to 5.3.3 #4930master
intonext
#4947This makes the package using ESM by default (
type: "module"
) and adjusts all scripts used.Some stuff like stylelint and eslint do not work correctly with ESM yet, so they are kept as commonjs scripts.
🏁 Checklist