Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds descriptive log, span event and records exception for stack trace. #45

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

miransar
Copy link

@miransar miransar commented Jul 26, 2024

Changes

Please provide a brief description of the changes here.

This PR adds the below to AdService

  • Descriptive log with error AdService failed { Unable to connect to database }
  • Span event with same error.
  • Records exception to generate a stack trace with same error.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@reese-lee
Copy link

@miransar I tested this in GH Codespace and it doesn't work using Docker, will you be adding changes so it will work with docker compose up? I haven't been able to test it using helm yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants