Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #66: Capture object representation on ChangeDiff when creating a new object within a branch #67

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Fixes #66: Capture object representation on ChangeDiff when creating a new object within a branch #67

merged 1 commit into from
Sep 4, 2024

Conversation

jeremystretch
Copy link
Contributor

Fixes: #66

Assign the object itself to the ChangeDiff, rather than just its type & ID, to ensure the instance can be cast to a string for the object_repr field.

arthanson
arthanson approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@arthanson arthanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is the display in question, approved. Note: You have Ruff check_annotations in other files, looks like a mismatch between the linter and pre-commit?
Change Diffs | NetBox 2024-09-04 07-33-56

@jeremystretch jeremystretch merged commit f6db858 into develop Sep 4, 2024
7 checks passed
@jeremystretch jeremystretch deleted the 66-fix-changediff-object_repr branch September 4, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthanson arthanson arthanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Object representation is not captured when creating a new object within a branch
2 participants
@jeremystretch @arthanson