Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safekeeper: downgrade interpreted reader errors #11034

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

erikgrinaker
Copy link
Contributor

Problem

This critical! could fire on IO errors, which is just noisy.

Resolves #11027.

Summary of changes

Downgrade to error, except for decode errors. These could be either data corruption or a bug, but seem worth investigating either way.

@erikgrinaker erikgrinaker requested a review from a team as a code owner February 28, 2025 09:31
Copy link

7744 tests run: 7365 passed, 0 failed, 379 skipped (full report)


Flaky tests (2)

Postgres 17

Postgres 14

Code coverage* (full report)

  • functions: 32.8% (8642 of 26363 functions)
  • lines: 48.6% (73201 of 150514 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d713047 at 2025-02-28T10:32:13.591Z :recycle:

@erikgrinaker erikgrinaker added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit c7ff3c4 Feb 28, 2025
92 checks passed
@erikgrinaker erikgrinaker deleted the erik/safekeeper-wal-critical branch February 28, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

safekeeper: critical!() can hit on S3 errors
3 participants