pageserver: https for management API #11025
Open
+563
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7755 tests run: 7375 passed, 0 failed, 380 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
2932a73 at 2025-02-28T11:18:49.458Z :recycle: |
DimasKovas
commented
Feb 28, 2025
| @@ -138,6 +139,10 @@ struct Cli { | |||
| // Flag to use https for requests to pageserver API. | |||
| #[arg(long, default_value = "false")] | |||
| use_https_pageserver_api: bool, | |||
|
|
|||
| #[arg(long)] | |||
| // Additional trusted root CA certificate. | |||
There was a problem hiding this comment.
Will move comment above #[arg(long)]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Storage controller uses unencrypted HTTP requests for pageserver management API.
Closes: /~https://github.com/neondatabase/cloud/issues/24283
Summary of changes
ssl_ca_fileoption to storcon for ability to use custom certificate authority.