ci: create multiarch vm images #11017
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7744 tests run: 7365 passed, 0 failed, 379 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
d69f1ff at 2025-02-27T14:55:05.757Z :recycle: |
mikhail-sakhnov
force-pushed
the
misha/build-vm-compute-images-for-arm
branch
from
43fe99d to
d69f1ff
Compare
fedordikarev
approved these changes
Feb 27, 2025
bayandin
reviewed
Feb 27, 2025
Comment on lines
+758
to
+765
| - pg: v14 | ||
| debian: bullseye | ||
| - pg: v15 | ||
| debian: bullseye | ||
| - pg: v16 | ||
| debian: bullseye | ||
| - pg: v17 | ||
| debian: bookworm |
There was a problem hiding this comment.
It seems we don't use ${{ matrix.version.debian }} in this job, so we can delete it from parameters:
Suggested change
| - pg: v14 | |
| debian: bullseye | |
| - pg: v15 | |
| debian: bullseye | |
| - pg: v16 | |
| debian: bullseye | |
| - pg: v17 | |
| debian: bookworm | |
| - pg: v14 | |
| - pg: v15 | |
| - pg: v16 | |
| - pg: v17 |
| vm-compute-node-image: | ||
| needs: [ vm-compute-node-image-arch, meta ] | ||
| if: ${{ contains(fromJSON('["push-main", "pr", "compute-release", "compute-rc-pr"]'), needs.meta.outputs.run-kind) }} | ||
| runs-on: [ self-hosted, large ] |
There was a problem hiding this comment.
In other jobs we just use GitHub-hosted runner for that
Suggested change
| runs-on: [ self-hosted, large ] | |
| runs-on: ubuntu-22.04 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We build compute-nodes as multi-arch images, but not the vm-compute-nodes. The PR adds multiarch vm images the same way as in autoscaling repo.
Summary of changes
Add architecture to the matrix for vm compute build steps
Add merge job