feat(pageserver): persist reldir v2 migration status #10980
+102
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Chi Z <chi@neon.tech>
13 tasks
705 tests run: 659 passed, 0 failed, 46 skipped (full report)Test coverage report is not availableThe comment gets automatically updated with the latest test results
3044fb6 at 2025-02-25T23:39:17.096Z :recycle: |
erikgrinaker
approved these changes
Feb 26, 2025
Comment on lines
+2896
to
+2897
| self.rel_size_v2_status | ||
| .store(Some(Arc::new(rel_size_v2_status.clone()))); |
There was a problem hiding this comment.
We should update this after the index upload is scheduled, since it can fail.
Also, nit: this is a bare enum, so we can derive Copy and avoid the cloning.
| @@ -2380,6 +2385,13 @@ impl Timeline { | |||
| .unwrap_or(self.conf.default_tenant_conf.rel_size_v2_enabled) | |||
| } | |||
|
|
|||
| pub(crate) fn get_rel_size_v2_status(&self) -> Option<RelSizeMigration> { | |||
There was a problem hiding this comment.
nit: would it be easier to just unwrap this to Legacy instead of propagating the None?
| @@ -1719,6 +1722,34 @@ impl DatadirModification<'_> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| /// Returns `true` if the rel_size_v2 write path is enabled. If it is the first time that | |||
| /// we enable it, we also need to persist it in `index_part.json`. | |||
| pub fn do_enable_rel_size_v2(&mut self) -> anyhow::Result<bool> { | |||
There was a problem hiding this comment.
nit: consider maybe_enable_rel_size_v2 since it is conditional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
part of #9516
Summary of changes
Similar to the aux v2 migration, we persist the relv2 migration status into index_part, so that even the config item is set to false, we will still read from the v2 storage to avoid loss of data.
Note that only the two variants
NoneandSome(RelSizeMigration::Migrating)are used for now. We don't have full migration implemented so it will never be set toRelSizeMigration::Migrated.