WIP: alternative approach to propagating per-timeline metrics down to VirtualFile #10962
+173
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t wrong, also detached_child and attached_child don't use ::extend())
…n; page_service's shard swapping turns out to be painful / requires `Handle: Clone`, don't want that
… still sucks & we still have a hot Arc::clone inside get_vectored_impl
No tests were run or test report is not availableTest coverage report is not availableThe comment gets automatically updated with the latest test results
d7c2379 at 2025-02-24T21:50:38.568Z :recycle: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #7202