Skip to content

Commit

Permalink
fix(ci): push prod container images again (#11020)
Browse files Browse the repository at this point in the history
## Problem
#10841 made building compute
and neon images optional on releases that don't need them. The
`push-<component>-image-prod` jobs had transitive dependencies that were
skipped due to that, causing the images not to be pushed to production
registries.

## Summary of changes

Add `!failure() && !cancelled() &&` to the beginning of the conditions
for these jobs to ensure they run even if some of their transitive
dependencies are skipped.
  • Loading branch information
jcgruenhage authored Feb 27, 2025
1 parent e58f264 commit 7ed236e
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -906,7 +906,8 @@ jobs:

push-neon-image-prod:
needs: [ meta, generate-image-maps, neon-image, test-images ]
if: ${{ contains(fromJSON('["storage-release", "proxy-release"]'), needs.meta.outputs.run-kind) }}
# Depends on jobs that can get skipped
if: ${{ !failure() && !cancelled() && contains(fromJSON('["storage-release", "proxy-release"]'), needs.meta.outputs.run-kind) }}
uses: ./.github/workflows/_push-to-container-registry.yml
permissions:
id-token: write # Required for aws/azure login
Expand All @@ -924,7 +925,8 @@ jobs:

push-compute-image-prod:
needs: [ meta, generate-image-maps, vm-compute-node-image, test-images ]
if: ${{ needs.meta.outputs.run-kind == 'compute-release' }}
# Depends on jobs that can get skipped
if: ${{ !failure() && !cancelled() && needs.meta.outputs.run-kind == 'compute-release' }}
uses: ./.github/workflows/_push-to-container-registry.yml
permissions:
id-token: write # Required for aws/azure login
Expand Down

1 comment on commit 7ed236e

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7896 tests run: 7505 passed, 1 failed, 390 skipped (full report)


Failures on Postgres 16

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_sharding_autosplit[release-pg16-github-actions-selfhosted]"
Flaky tests (4)

Postgres 17

Postgres 14

Code coverage* (full report)

  • functions: 32.8% (8643 of 26359 functions)
  • lines: 48.7% (73220 of 150478 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
7ed236e at 2025-02-27T18:56:42.797Z :recycle:

Please sign in to comment.