#Vulcan-283/Dynamic browser tab titles.

[m-o-n-i-s-h]

Problem
Users finds difficult to navigate between browser tabs. If there are many dashboards opened.

Solution
Implemented a component which will dynamically change the browser tab title. For my users use case, we have used dashboard name.

NOTICE
The program was tested solely for our own use cases, which might differ from yours.

Author Info: Monish monish.nandakumaran@mercedes-benz.com on behalf of Mercedes-Benz Research and Development India
/~https://github.com/mercedes-benz/mercedes-benz-foss/blob/master/PROVIDER_INFORMATION.md

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1a4bb4b) 46.26% compared to head (11be3fc) 46.28%.
Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #613      +/-   ##
===========================================
+ Coverage    46.26%   46.28%   +0.02%     
===========================================
  Files          166      167       +1     
  Lines         6591     6594       +3     
  Branches      2040     2042       +2     
===========================================
+ Hits          3049     3052       +3     
  Misses        3501     3501              
  Partials        41       41              

Files	Coverage Δ
src/component/page/PageHeader.tsx	100.00% <100.00%> (ø)
src/dashboard/header/DashboardTitle.tsx	58.33% <100.00%> (+0.88%)	⬆️
src/index.tsx	85.71% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nielsdejong]

Hi @m-o-n-i-s-h ,
I think is a great feature and could potentially be useful to our users.
I'm wondering if it's possible to accomplish the same without the extra dependency on react-helmet-async.
Is there a reason you opted for the dependency as opposed to simple setting the document title before the dashboard title dispatch is called? e.g.

document.title = title; 
dispatch(setDashboardTitle(title));

Let me know what you think,
Niels

[m-o-n-i-s-h]

Hi @nielsdejong ,

Yes it is possible to achieve the same without the dependency as you mentioned in your comments.

The reason why I opted react-helmet-async is we have custom favicon to be displayed (Which I have not included in this PR as it won't add any value to neodash in general) and in future for our usecase we may need to add meta description tag with dynamic content for SEO purpose.

If you think it will be an overkill. I would be happy to create a new PR with the simple implementation as you mentioned.

Kindly let me know.

Thank you,
Monish

[m-o-n-i-s-h]

Created a new PR #708 #708