Convert to Neo.Json and Neo.ConsoleService to dotnet standard 2.1

.github/workflows/main.yml

@@ -36,6 +36,7 @@ jobs:
       uses: coverallsapp/github-action@master
       with:
         github-token: ${{ secrets.GITHUB_TOKEN }}
+        path-to-lcov: ./coverage/lcov.net7.0.info
 
   # MyGet isn't working
   # PublishMyGet:

src/Directory.Build.props

@@ -5,7 +5,6 @@
     <Copyright>2015-2023 The Neo Project</Copyright>
     <VersionPrefix>3.6.2</VersionPrefix>
     <Authors>The Neo Project</Authors>
-    <TargetFrameworks>net7.0</TargetFrameworks>
     <PackageIcon>neo.png</PackageIcon>
     <PackageProjectUrl>/~https://github.com/neo-project/neo</PackageProjectUrl>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>

src/Neo.CLI/Neo.CLI.csproj

@@ -1,6 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
+    <TargetFrameworks>net7.0</TargetFrameworks>
     <AssemblyTitle>Neo.CLI</AssemblyTitle>
     <AssemblyName>neo-cli</AssemblyName>
     <OutputType>Exe</OutputType>

src/Neo.CLI/Settings.cs

@@ -51,10 +51,10 @@ public static Settings Default
 
         public Settings(IConfigurationSection section)
         {
-            this.Logger = new(section.GetSection("Logger"));
-            this.Storage = new(section.GetSection("Storage"));
-            this.P2P = new(section.GetSection("P2P"));
-            this.UnlockWallet = new(section.GetSection("UnlockWallet"));
+            Logger = new(section.GetSection(nameof(Logger)));
+            Storage = new(section.GetSection(nameof(Storage)));
+            P2P = new(section.GetSection(nameof(P2P)));
+            UnlockWallet = new(section.GetSection(nameof(UnlockWallet)));
         }
     }
 
@@ -66,21 +66,21 @@ public class LoggerSettings
 
         public LoggerSettings(IConfigurationSection section)
         {
-            this.Path = section.GetValue("Path", "Logs")!;
-            this.ConsoleOutput = section.GetValue("ConsoleOutput", false);
-            this.Active = section.GetValue("Active", false);
+            Path = section.GetValue(nameof(Path), "Logs")!;
+            ConsoleOutput = section.GetValue(nameof(ConsoleOutput), false);
+            Active = section.GetValue(nameof(Active), false);
         }
     }
 
     public class StorageSettings
     {
-        public string Engine { get; }
-        public string Path { get; }
+        public string Engine { get; } = string.Empty;
+        public string Path { get; } = string.Empty;
 
         public StorageSettings(IConfigurationSection section)
         {
-            this.Engine = section.GetValue("Engine", "LevelDBStore")!;
-            this.Path = section.GetValue("Path", "Data_LevelDB_{0}")!;
+            Engine = section.GetValue(nameof(Engine), "LevelDBStore")!;
+            Path = section.GetValue(nameof(Path), "Data_LevelDB_{0}")!;
         }
     }
 
@@ -93,26 +93,26 @@ public class P2PSettings
 
         public P2PSettings(IConfigurationSection section)
         {
-            this.Port = section.GetValue<ushort>("Port", 10333);
-            this.MinDesiredConnections = section.GetValue("MinDesiredConnections", Peer.DefaultMinDesiredConnections);
-            this.MaxConnections = section.GetValue("MaxConnections", Peer.DefaultMaxConnections);
-            this.MaxConnectionsPerAddress = section.GetValue("MaxConnectionsPerAddress", 3);
+            Port = section.GetValue<ushort>(nameof(Port), 10333);
+            MinDesiredConnections = section.GetValue(nameof(MinDesiredConnections), Peer.DefaultMinDesiredConnections);
+            MaxConnections = section.GetValue(nameof(MaxConnections), Peer.DefaultMaxConnections);
+            MaxConnectionsPerAddress = section.GetValue(nameof(MaxConnectionsPerAddress), 3);
         }
     }
 
     public class UnlockWalletSettings
     {
-        public string? Path { get; }
-        public string? Password { get; }
-        public bool IsActive { get; }
+        public string Path { get; } = string.Empty;
+        public string Password { get; } = string.Empty;
+        public bool IsActive { get; } = false;
 
         public UnlockWalletSettings(IConfigurationSection section)
         {
             if (section.Exists())
             {
-                this.Path = section.GetValue("Path", "");
-                this.Password = section.GetValue("Password", "");
-                this.IsActive = bool.Parse(section.GetValue("IsActive", "false")!);
+                Path = section.GetValue(nameof(Path), string.Empty)!;
+                Password = section.GetValue(nameof(Password), string.Empty)!;
+                IsActive = section.GetValue(nameof(IsActive), false);
             }
         }
     }

src/Neo.ConsoleService/ConsoleServiceBase.cs

@@ -491,8 +491,10 @@ public void Run(string[] args)
             }
             else
             {
-                Debug.Assert(OperatingSystem.IsWindows());
+                Debug.Assert(Environment.OSVersion.Platform == PlatformID.Win32NT);
+#pragma warning disable CA1416
                 ServiceBase.Run(new ServiceProxy(this));
+#pragma warning restore CA1416
             }
         }
 

src/Neo.ConsoleService/Neo.ConsoleService.csproj

@@ -1,6 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
+    <TargetFrameworks>netstandard2.1;net7.0</TargetFrameworks>
+    <LangVersion>10.0</LangVersion>
     <PackageId>Neo.ConsoleService</PackageId>
     <Nullable>enable</Nullable>
   </PropertyGroup>

src/Neo.ConsoleService/System/IsExternalInit.cs

@@ -0,0 +1,15 @@
+// Copyright (C) 2015-2024 The Neo Project.
+//
+// IsExternalInit.cs file belongs to the neo project and is free
+// software distributed under the MIT software license, see the
+// accompanying file LICENSE in the main directory of the
+// repository or http://www.opensource.org/licenses/mit-license.php
+// for more details.
+//
+// Redistribution and use in source and binary forms with or without
+// modifications are permitted.
+
+namespace System.Runtime.CompilerServices
+{
+    internal static class IsExternalInit { }
+}

src/Neo.Json/JArray.cs

@@ -123,7 +123,7 @@ internal override void Write(Utf8JsonWriter writer)
             writer.WriteEndArray();
         }
 
-        public override JArray Clone()
+        public override JToken Clone()
         {
             var cloned = new JArray();
 

src/Neo.Json/JBoolean.cs

@@ -63,7 +63,7 @@ internal override void Write(Utf8JsonWriter writer)
             writer.WriteBooleanValue(Value);
         }
 
-        public override JBoolean Clone()
+        public override JToken Clone()
         {
             return this;
         }

src/Neo.Json/JNumber.cs

@@ -109,7 +109,7 @@ internal override void Write(Utf8JsonWriter writer)
             writer.WriteNumberValue(Value);
         }
 
-        public override JNumber Clone()
+        public override JToken Clone()
         {
             return this;
         }

src/Neo.Json/JObject.cs

@@ -76,7 +76,7 @@ internal override void Write(Utf8JsonWriter writer)
         /// Creates a copy of the current JSON object.
         /// </summary>
         /// <returns>A copy of the current JSON object.</returns>
-        public override JObject Clone()
+        public override JToken Clone()
         {
             var cloned = new JObject();
 

src/Neo.Json/JString.cs

@@ -70,7 +70,7 @@ public override T AsEnum<T>(T defaultValue = default, bool ignoreCase = false)
         public override T GetEnum<T>(bool ignoreCase = false)
         {
             T result = Enum.Parse<T>(Value, ignoreCase);
-            if (!Enum.IsDefined(result)) throw new InvalidCastException();
+            if (!Enum.IsDefined(typeof(T), result)) throw new InvalidCastException();
             return result;
         }
 
@@ -79,7 +79,7 @@ internal override void Write(Utf8JsonWriter writer)
             writer.WriteStringValue(Value);
         }
 
-        public override JString Clone()
+        public override JToken Clone()
         {
             return this;
         }

src/Neo.Json/Neo.Json.csproj

@@ -1,9 +1,15 @@
-<Project Sdk="Microsoft.NET.Sdk">
-
-  <PropertyGroup>
-    <ImplicitUsings>enable</ImplicitUsings>
-    <Nullable>enable</Nullable>
-    <PackageTags>NEO;JSON</PackageTags>
-  </PropertyGroup>
-
-</Project>
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFrameworks>netstandard2.1;net7.0</TargetFrameworks>
+    <LangVersion>10.0</LangVersion>
+    <ImplicitUsings>enable</ImplicitUsings>
+    <Nullable>enable</Nullable>
+    <PackageTags>NEO;JSON</PackageTags>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="System.Text.Json" Version="8.0.0" />
+  </ItemGroup>
+
+</Project>

src/Neo/Neo.csproj

@@ -1,6 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
+    <TargetFrameworks>net7.0</TargetFrameworks>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <PackageTags>NEO;AntShares;Blockchain;Smart Contract</PackageTags>
   </PropertyGroup>

tests/Neo.ConsoleService.Tests/Neo.ConsoleService.Tests.csproj

@@ -1,7 +1,9 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
+    <TargetFrameworks>net7.0</TargetFrameworks>
     <RootNamespace>neo_cli.Tests</RootNamespace>
+    <IsPackable>false</IsPackable>
   </PropertyGroup>
 
   <ItemGroup>

tests/Neo.Json.UnitTests/Neo.Json.UnitTests.csproj

@@ -1,15 +1,17 @@
-<Project Sdk="Microsoft.NET.Sdk">
-
-  <PropertyGroup>
-    <ImplicitUsings>enable</ImplicitUsings>
-  </PropertyGroup>
-
-  <ItemGroup>
-    <ProjectReference Include="..\..\src\Neo.Json\Neo.Json.csproj" />
-  </ItemGroup>
-
-  <ItemGroup>
-    <PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.8.0" />
-  </ItemGroup>
-
-</Project>
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFrameworks>net7.0</TargetFrameworks>
+    <ImplicitUsings>enable</ImplicitUsings>
+    <IsPackable>false</IsPackable>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <ProjectReference Include="..\..\src\Neo.Json\Neo.Json.csproj" />
+  </ItemGroup>
+
+  <ItemGroup>
+    <PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.8.0" />
+  </ItemGroup>
+
+</Project>

tests/Neo.Json.UnitTests/UT_JObject.cs

@@ -117,7 +117,7 @@ public void TestGetNull()
         [TestMethod]
         public void TestClone()
         {
-            var bobClone = bob.Clone();
+            var bobClone = (JObject)bob.Clone();
             bobClone.Should().NotBeSameAs(bob);
             foreach (var key in bobClone.Properties.Keys)
             {

tests/Neo.UnitTests/Neo.UnitTests.csproj

@@ -1,7 +1,9 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
+    <TargetFrameworks>net7.0</TargetFrameworks>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
+    <IsPackable>false</IsPackable>
   </PropertyGroup>
 
   <ItemGroup>