move neo-core projects into a dependency folder to make it clear. #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not move to neo-core the devpack instead? I think we should archive here as we discussed in the examples PR. |
|
shargon
approved these changes
Jan 19, 2024
Jim8y
added a commit
to Jim8y/neo-devpack-dotnet
that referenced
this pull request
Jan 31, 2024
* master: [Framework: Add] Define Standard Enum (neo-project#877) Fix: Fix dependency (neo-project#876) create seperate test contracts (neo-project#868) fix-nep11token (neo-project#874) add comments to statements (neo-project#875) move neo-core projects into a dependency folder to make it clear. (neo-project#871)
Jim8y
added a commit
to Jim8y/neo-devpack-dotnet
that referenced
this pull request
Feb 10, 2024
* master: (28 commits) Reduce notifications (neo-project#888) Core optimize optimizer (neo-project#887) print-stack (neo-project#873) ZipArchive use utf8; simplify GetOperandString [Compiler] move expressions out of convert file. (neo-project#882) misc refactor Zip and Unzip methods for files only add optimize test add debug notify into contract (neo-project#872) [Compiler: Add]verify the NEP11 and NEP17 standards while compile them. (neo-project#881) [Compiler: Comment] add comment to initial value (neo-project#880) refactor move to folder `Optimizer` optimizer to remove unused instructions [Framework: Add] Define Standard Enum (neo-project#877) Fix: Fix dependency (neo-project#876) create seperate test contracts (neo-project#868) fix-nep11token (neo-project#874) add comments to statements (neo-project#875) move neo-core projects into a dependency folder to make it clear. (neo-project#871) ...
Jim8y
added a commit
to Jim8y/neo-devpack-dotnet
that referenced
this pull request
Feb 11, 2024
* master: (28 commits) Reduce notifications (neo-project#888) Core optimize optimizer (neo-project#887) print-stack (neo-project#873) ZipArchive use utf8; simplify GetOperandString [Compiler] move expressions out of convert file. (neo-project#882) misc refactor Zip and Unzip methods for files only add optimize test add debug notify into contract (neo-project#872) [Compiler: Add]verify the NEP11 and NEP17 standards while compile them. (neo-project#881) [Compiler: Comment] add comment to initial value (neo-project#880) refactor move to folder `Optimizer` optimizer to remove unused instructions [Framework: Add] Define Standard Enum (neo-project#877) Fix: Fix dependency (neo-project#876) create seperate test contracts (neo-project#868) fix-nep11token (neo-project#874) add comments to statements (neo-project#875) move neo-core projects into a dependency folder to make it clear. (neo-project#871) ... # Conflicts: # src/Neo.Compiler.CSharp/MethodConvert.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just find it misleading to mix everything in the src folder. so move the neo-core to a dependency folder. No logic is changed