Disable AWS launch_template
from nebari-config schema
#2856
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
What does this implement/fix?
This PR disables the user-facing object from the nebari-config schema while still keeping the logic introduced initially in #2621.
Motivation
The #2842 attempted to disable the
ami_id
setting from thelaunch_template
configuration under the node groups. However, this change caused Terraform deployment issues because the aws node_group relied on theami_id
attribute internaly, leading to a failed Nebari deployments when it was removed in the linked PR.Additionally, we've encountered recent internal connection issues with the nodes using just the
pre_bootstrap_command.
These issues indicated that the current configuration forlaunch_template
is not functioning correctly.It also includes:
construct_aws_ami_type
function since the choice for the CUSTOM instance type depends on the presence of bothlaunch_template
andami_id
.Put a
x
in the boxes that applyTesting
How to test this PR?
launch_template
field. This would simulate a scenario where the user has such a config already (for example):Though, just adding
launch_template
will trigger the error.nebari render
ornebari validate
to trigger the load of the schemas. This should lead you to a ValueErrorAny other comments?