Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disallowed nebari config changes #2660

Merged
merged 12 commits into from
Aug 30, 2024
Merged

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Aug 28, 2024

Reference Issues or PRs

Fixes #2607
Probably best to start with src/_nebari/stages/terraform_state/init.py on the PR Reviews.

I decided to add the immutability check at the beginning of Stage 01 instead of between Stage 01 and Stage 02 as originally described in #2607 (comment).

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@Adam-D-Lewis Adam-D-Lewis requested a review from aktech August 29, 2024 20:17
@Adam-D-Lewis Adam-D-Lewis added the project: JATIC Work item needed for the JATIC project label Aug 29, 2024
@Adam-D-Lewis Adam-D-Lewis marked this pull request as ready for review August 30, 2024 00:05
@Adam-D-Lewis Adam-D-Lewis self-assigned this Aug 30, 2024
Copy link
Contributor

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @Adam-D-Lewis , Thanks. Works as advertised

@Adam-D-Lewis Adam-D-Lewis merged commit fa37324 into develop Aug 30, 2024
28 checks passed
@Adam-D-Lewis Adam-D-Lewis deleted the store_nebari_config branch August 30, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: JATIC Work item needed for the JATIC project
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[ENH] - Prevent unsupported changes to the nebari-config file
3 participants