Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip running cleanup on pull requests #2488

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Skip running cleanup on pull requests #2488

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4edc7aa
Skip running cleanup on pull requests
aktech May 28, 2024
3e0f9c4
update triggers for local integration tests
aktech May 31, 2024
ccd5df9
Merge branch 'develop' into skip-cleanup-on-pr
aktech May 31, 2024
294f62a
Merge branch 'develop' into skip-cleanup-on-pr
aktech May 31, 2024
1cabcc8
Merge branch 'develop' into skip-cleanup-on-pr
aktech Jun 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/test_local_integration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ on:
pr_number:
required: true
type: string
workflow_dispatch:

# When the cancel-in-progress: true option is specified, any concurrent jobs or workflows using the same
# concurrency group will cancel both the pending and currently running jobs or workflows. This allows only
Expand Down Expand Up @@ -192,7 +193,10 @@ jobs:

### CLEANUP AFTER TESTS
- name: Cleanup nebari deployment
if: always()
# Since this is not critical for most pull requests and takes more than half of the time
# in the CI, it makes sense to only run on merge to main or workflow_dispatch to speed
# up feedback cycle
if: github.ref_name == 'develop' || github.event_name == 'workflow_dispatch'
working-directory: local-deployment
run: |
nebari destroy --config nebari-config.yaml --disable-prompt