Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nebari validate unit tests #1938

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

sblair-metrostar
Copy link
Contributor

Reference Issues or PRs

#1862

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe): Unit tests

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@kcpevey
Copy link
Contributor

kcpevey commented Aug 25, 2023

@sblair-metrostar is this ready for review?

@sblair-metrostar
Copy link
Contributor Author

@sblair-metrostar is this ready for review?

Yes, this is just unit tests, nothing functional. Also not intended to be 100% coverage out of the gate, just an initial set of tests that we can build on as we go. This one specifically assumes we'll want to add yaml config files over time and they'll automatically get picked up as additional test cases.

@pavithraes pavithraes added the status: in review 👀 This PR is currently being reviewed by the team label Aug 28, 2023
@iameskild iameskild self-requested a review August 28, 2023 16:30
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sblair-metrostar for the testing updates!

As I mentioned to you offline, we might want to try and write a fixture that generates these config files but this is something we can tackle in the future; I've added it to the testing improvements meta issue.

@iameskild iameskild merged commit 40cfb49 into nebari-dev:develop Aug 28, 2023
@fangchenli fangchenli mentioned this pull request Aug 29, 2023
10 tasks
@iameskild
Copy link
Member

Related to #1955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: nebari-cli area: testing ✅ Testing status: in review 👀 This PR is currently being reviewed by the team
Projects
Development

Successfully merging this pull request may close these issues.

4 participants