Move code for starting new routing table sync to RoutingTableActor #5163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mm-near @bowenwang1996 Can you take a look? |
pmnoxx
added
A-network
mm-near
approved these changes
Nov 8, 2021
| @@ -68,6 +68,10 @@ pub enum RoutingTableMessages { | |||
| peer_id: PeerId, | |||
| ibf_msg: RoutingVersion2, | |||
| }, | |||
| #[cfg(feature = "protocol_feature_routing_exchange_algorithm")] | |||
| StartRoutingTableSync { | |||
There was a problem hiding this comment.
let's start improving the documentation:
can you add the description of what will happen when this message is received?
There was a problem hiding this comment.
Yes, once we merge other PR changes I'll add documentation.
pmnoxx
deleted the
piotr-move-routing-table-exchange-to-another-thread-pt2-pt1.5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for moving routing table computation to
RoutingTableActor, we should move handlingstart_routing_table_syncv2fromPeerManagertoRoutingTableActorfirst.Related to #5138
Change extracted from #5089, to make that PR shorter.