Refactor proposal: simpler variables #968

luixo · 2022-04-29T13:58:05Z

I'm not sure that's the way, but I would like to hear your opinions

backend/src/db-utils.ts

shelegdmitriy

There is much better to follow up the code, I like it

luixo · 2022-05-10T12:04:50Z

It took quite a research to make both next build and jest work with common modules though it works now.
We'll probably migrate to swc + custom plugin for stitches friendly class names instead of babel later, but it'll take a PR in next.js team (I'll open an issue later).

update: there is a PR on that, actually: vercel/next.js#36790

luixo requested a review from frol April 29, 2022 13:58

luixo self-assigned this Apr 29, 2022

luixo requested a review from shelegdmitriy as a code owner April 29, 2022 13:58

luixo deployed to refactor/variables-simpler - wamp PR #968 April 29, 2022 13:58 — with Render View deployment

luixo had a problem deploying to refactor/variables-simpler - backend/testnet PR #968 April 29, 2022 14:00 — with Render Failure

luixo had a problem deploying to refactor/variables-simpler - backend/mainnet PR #968 April 29, 2022 14:00 — with Render Failure

luixo had a problem deploying to refactor/variables-simpler - backend/guildnet PR #968 April 29, 2022 14:00 — with Render Failure

luixo deployed to refactor/variables-simpler - frontend PR #968 April 29, 2022 14:01 — with Render View deployment

luixo force-pushed the refactor/variables-simpler branch from b6a269b to 55473f6 Compare April 29, 2022 17:44

luixo deployed to refactor/variables-simpler - wamp PR #968 April 29, 2022 17:45 — with Render View deployment

luixo temporarily deployed to refactor/variables-simpler - frontend PR #968 April 29, 2022 17:45 — with Render Destroyed

luixo had a problem deploying to refactor/variables-simpler - backend/testnet PR #968 April 29, 2022 17:45 — with Render Failure

luixo had a problem deploying to refactor/variables-simpler - backend/mainnet PR #968 April 29, 2022 17:45 — with Render Failure

luixo had a problem deploying to refactor/variables-simpler - backend/guildnet PR #968 April 29, 2022 17:45 — with Render Failure

luixo deployed to refactor/variables-simpler - frontend PR #968 April 29, 2022 17:45 — with Render View deployment

luixo force-pushed the refactor/variables-simpler branch from 55473f6 to fc04a4a Compare April 29, 2022 22:03

luixo deployed to refactor/variables-simpler - wamp PR #968 April 29, 2022 22:03 — with Render View deployment

luixo had a problem deploying to refactor/variables-simpler - backend/testnet PR #968 April 29, 2022 22:03 — with Render Failure

luixo had a problem deploying to refactor/variables-simpler - backend/mainnet PR #968 April 29, 2022 22:03 — with Render Failure

luixo had a problem deploying to refactor/variables-simpler - backend/guildnet PR #968 April 29, 2022 22:03 — with Render Failure

luixo deployed to refactor/variables-simpler - frontend PR #968 April 29, 2022 22:03 — with Render View deployment

luixo force-pushed the refactor/variables-simpler branch from fc04a4a to 1eaaf73 Compare April 30, 2022 09:55

luixo deployed to refactor/variables-simpler - wamp PR #968 April 30, 2022 09:55 — with Render View deployment

luixo had a problem deploying to refactor/variables-simpler - backend/testnet PR #968 April 30, 2022 09:55 — with Render Failure

luixo had a problem deploying to refactor/variables-simpler - backend/mainnet PR #968 April 30, 2022 09:55 — with Render Failure

luixo had a problem deploying to refactor/variables-simpler - backend/guildnet PR #968 April 30, 2022 09:55 — with Render Failure

luixo deployed to refactor/variables-simpler - frontend PR #968 April 30, 2022 09:55 — with Render View deployment

shelegdmitriy reviewed May 2, 2022

View reviewed changes

backend/src/db-utils.ts Show resolved Hide resolved

shelegdmitriy reviewed May 2, 2022

View reviewed changes

luixo had a problem deploying to refactor/variables-simpler - wamp PR #968 May 2, 2022 16:51 — with Render Failure

luixo temporarily deployed to refactor/variables-simpler - wamp PR #968 May 9, 2022 14:43 — with Render Destroyed

luixo requested a deployment to refactor/variables-simpler - backend/testnet PR #968 May 9, 2022 14:43 — with Render In progress

luixo requested a deployment to refactor/variables-simpler - backend/guildnet PR #968 May 9, 2022 14:43 — with Render In progress

luixo requested a deployment to refactor/variables-simpler - backend/mainnet PR #968 May 9, 2022 14:43 — with Render In progress

luixo requested a deployment to refactor/variables-simpler - frontend PR #968 May 9, 2022 14:43 — with Render In progress

luixo temporarily deployed to refactor/variables-simpler - backend/mainnet PR #968 May 9, 2022 14:43 — with Render Destroyed

luixo temporarily deployed to refactor/variables-simpler - backend/testnet PR #968 May 9, 2022 14:43 — with Render Destroyed

luixo temporarily deployed to refactor/variables-simpler - backend/guildnet PR #968 May 9, 2022 14:43 — with Render Destroyed

luixo temporarily deployed to refactor/variables-simpler - frontend PR #968 May 9, 2022 14:43 — with Render Destroyed

luixo temporarily deployed to refactor/variables-simpler - wamp PR #968 May 9, 2022 14:43 — with Render Destroyed

luixo had a problem deploying to refactor/variables-simpler - backend/testnet PR #968 May 9, 2022 14:43 — with Render Failure

luixo temporarily deployed to refactor/variables-simpler - backend/mainnet PR #968 May 9, 2022 14:43 — with Render Destroyed

luixo temporarily deployed to refactor/variables-simpler - backend/guildnet PR #968 May 9, 2022 14:43 — with Render Destroyed

luixo temporarily deployed to refactor/variables-simpler - frontend PR #968 May 9, 2022 14:43 — with Render Destroyed

Common package

2061221

luixo force-pushed the refactor/variables-simpler branch from 2ab36bd to 2061221 Compare May 9, 2022 14:46

luixo deployed to refactor/variables-simpler - wamp PR #968 May 9, 2022 14:46 — with Render View deployment

luixo deployed to refactor/variables-simpler - backend/mainnet PR #968 May 9, 2022 14:46 — with Render Active

luixo deployed to refactor/variables-simpler - backend/testnet PR #968 May 9, 2022 14:46 — with Render Active

luixo deployed to refactor/variables-simpler - frontend PR #968 May 9, 2022 14:46 — with Render View deployment

luixo deployed to refactor/variables-simpler - backend/guildnet PR #968 May 9, 2022 14:46 — with Render Active

babelrc wrapper

b57edab

luixo temporarily deployed to refactor/variables-simpler - wamp PR #968 May 10, 2022 12:02 — with Render Destroyed

luixo temporarily deployed to refactor/variables-simpler - backend/mainnet PR #968 May 10, 2022 12:02 — with Render Destroyed

luixo temporarily deployed to refactor/variables-simpler - backend/testnet PR #968 May 10, 2022 12:02 — with Render Destroyed

luixo temporarily deployed to refactor/variables-simpler - frontend PR #968 May 10, 2022 12:02 — with Render Destroyed

luixo temporarily deployed to refactor/variables-simpler - backend/guildnet PR #968 May 10, 2022 12:02 — with Render Destroyed

luixo merged commit 5ff970a into master May 10, 2022

luixo deleted the refactor/variables-simpler branch May 10, 2022 12:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor proposal: simpler variables #968

Refactor proposal: simpler variables #968

luixo commented Apr 29, 2022

shelegdmitriy left a comment •

edited

Loading

luixo commented May 10, 2022 •

edited

Loading

Refactor proposal: simpler variables #968

Refactor proposal: simpler variables #968

Conversation

luixo commented Apr 29, 2022

shelegdmitriy left a comment • edited Loading

Choose a reason for hiding this comment

luixo commented May 10, 2022 • edited Loading

shelegdmitriy left a comment •

edited

Loading

luixo commented May 10, 2022 •

edited

Loading