Update trusted CA certificates #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #230 blocked updating trusted CA certificates to 2048 bit version long time. But from OpenSSL 1.0.1m and 1.0.2a it changes their custom chain building algorithm to find shortcut path when it fails to validate the path SSL server returns so that we can migrate trusted CA certificates to 2048bit version atop OpenSSL. Unfortunately the new algorithm has CVE-2015-1793 problem so we can use this new algorithm actually from OpenSSL >= 1.0.1p or >= 1.0.2d. (Jul 2015) After this commit HTTPClient leverages 2048 bit version of trusted CA certificates if ruby is compiled with proper version of OpenSSL. ``` ver = OpenSSL::OPENSSL_VERSION if (ver.start_with?('OpenSSL 1.0.1') && ver >= 'OpenSSL 1.0.1p') || (ver.start_with?('OpenSSL ') && ver >= 'OpenSSL 1.0.2d') filename = 'cacert.pem' else filename = 'cacert1024.pem' end ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #230 blocked updating trusted CA certificates to 2048 bit version
long time. But from OpenSSL 1.0.1m and 1.0.2a it changes their custom
chain building algorithm to find shortcut path when it fails to validate
the path SSL server returns so that we can migrate trusted CA
certificates to 2048bit version atop OpenSSL.
Unfortunately the new algorithm has CVE-2015-1793 problem so we can use
this new algorithm actually from OpenSSL >= 1.0.1p or >= 1.0.2d. (Jul
2015)
After this commit HTTPClient leverages 2048 bit version of trusted CA
certificates if ruby is compiled with proper version of OpenSSL.