Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Unify task runner env vars #52

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

tomi
Copy link
Contributor

@tomi tomi commented Dec 4, 2024

  • Rename N8N_TASK_BROKER_URI to N8N_RUNNERS_TASK_BROKER_URI
  • Rename N8N_RUNNERS_SERVER_ENABLED to N8N_RUNNERS_HEALTH_CHECK_SERVER_ENABLED
  • Rename N8N_LAUNCHER_HEALTH_CHECK_PORT to N8N_RUNNERS_LAUNCHER_HEALTH_CHECK_PORT
  • Rename N8N_LAUNCHER_LOG_LEVEL to N8N_RUNNERS_LAUNCHER_LOG_LEVEL

Related PR: n8n-io/n8n#12040

- Rename `N8N_TASK_BROKER_URI` to `N8N_RUNNERS_TASK_BROKER_URI`
- Rename `N8N_RUNNERS_SERVER_ENABLED` to `N8N_RUNNERS_HEALTH_CHECK_SERVER_ENABLED`
- `N8N_LAUNCHER_HEALTH_CHECK_PORT` to `N8N_RUNNERS_LAUNCHER_HEALTH_CHECK_PORT`
- `N8N_LAUNCHER_LOG_LEVEL` to `N8N_RUNNERS_LAUNCHER_LOG_LEVEL`
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/config/config.go 0.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

internal/env/env.go Show resolved Hide resolved
@tomi tomi merged commit fe8429f into main Dec 5, 2024
2 checks passed
@tomi tomi deleted the refactor-unify-runner-env-vars branch December 5, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants