Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Encapsulate health check server logic #46

Merged
merged 1 commit into from
Dec 2, 2024
Merged

refactor: Encapsulate health check server logic #46

merged 1 commit into from
Dec 2, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Dec 2, 2024

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/http/healthcheck_server.go 7.14% 13 Missing ⚠️
cmd/launcher/main.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

tomi
tomi approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ivov ivov merged commit a71cd1c into main Dec 2, 2024
2 checks passed
@ivov ivov deleted the refactor-encapsulate-health-check-server-logic branch December 2, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomi tomi tomi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivov @codecov-commenter @tomi