refactor: Simplify configuration #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove`N8N_RUNNER_URI` and `N8N_RUNNERS_SERVER_ENABLED` env vars. These can be statically. For the launcher to be able to monitor the runner, the `N8N_RUNNERS_SERVER_ENABLED` env var needs to be set to `true`. Hence there's not reason to let it be configurable. Same applies for `N8N_RUNNER_URI`, which we know is going to be localhost, since the launcher starts the runner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
N8N_RUNNER_URIandN8N_RUNNERS_SERVER_ENABLEDenv vars. These can be statically. For the launcher to be able to monitor the runner, theN8N_RUNNERS_SERVER_ENABLEDenv var needs to be set totrue. Hence there's not reason to let it be configurable. Same applies forN8N_RUNNER_URI, which we know is going to be localhost, since the launcher starts the runner.