Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Stay active on n8n instance crash #24

Merged
merged 4 commits into from
Nov 27, 2024
Merged

feat: Stay active on n8n instance crash #24

merged 4 commits into from
Nov 27, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Nov 26, 2024

This PR ensures the launcher process stays active during an n8n instance crash and tries to reconnect once n8n is back up again.

https://linear.app/n8n/issue/CAT-352

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/commands/launch.go 0.00% 12 Missing ⚠️
internal/auth/handshake.go 0.00% 11 Missing ⚠️
internal/http/wait_for_n8n.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

tomi
tomi requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things to address

internal/launcherr/launcherr.go Outdated Show resolved Hide resolved
internal/auth/handshake.go Outdated Show resolved Hide resolved
@ivov ivov requested a review from tomi November 27, 2024 09:05
tomi
tomi approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely now 👏

@ivov ivov merged commit d4e105b into main Nov 27, 2024
2 checks passed
@ivov ivov deleted the stay-active-on-instance-crash branch November 27, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomi tomi tomi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivov @codecov-commenter @tomi