Add connection setup helpers to the quinn transport. #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copying and updating these gets really old. This also fixes a bug in the fn make_insecure_client_endpoint that would not support any verification schemes, causing the split example to fail. We also add some top level type aliases and fns for creating channels for mem and testing.
no luck so far...
# Conflicts: # src/lib.rs
XXXListener to server and XXXConnector to client where the BoxedListener and BoxedConnector type aliases already live
| @@ -0,0 +1,32 @@ | |||
| Building docs for this crate is a bit complex. There are lots of feature flags, | |||
There was a problem hiding this comment.
I think is file is usually called CONTRIBUTING.md
| #![deny(missing_docs)] | ||
| #![deny(rustdoc::broken_intra_doc_links)] | ||
| #![cfg_attr(quicrpc_docsrs, feature(doc_cfg))] |
There was a problem hiding this comment.
if you use the auto thing @flub found, you can simplify this: n0-computer/iroh#3029
There was a problem hiding this comment.
Yeah, will do at some point. But I am afraid that I will spend another few hours on this, so I will wait for 1 iroh release before converting to the auto stuff...
dignifiedquire
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying and updating these gets really old.
This also fixes a bug in the fn make_insecure_client_endpoint that would not support any verification schemes, causing the split example to fail.
We also add some top level type aliases and fns for creating channels for mem and testing.
We get a dependency on rcgen and rustls, but only if you set the "test-utils" feature flag. Everybody that wants to use the quinn transport is going to want such tests in their crate, and this way we can do the whole setup only once.