refactor: rename iroh-net transport to iroh-transport #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renamed - the module iroh_net -> iroh - the connector IrohNetConnector to IrohConnector - the listener IrohNetListener to IrohListener - the feature flag "iroh-net-transport" to "iroh-transport"
flub
approved these changes
Nov 29, 2024
Cargo.toml
Outdated
| @@ -58,7 +58,7 @@ tokio-util = { version = "0.7", features = ["rt"] } | |||
| hyper-transport = ["dep:flume", "dep:hyper", "dep:postcard", "dep:bytes", "dep:tokio-serde", "tokio-util/codec"] | |||
| quinn-transport = ["dep:flume", "dep:quinn", "dep:postcard", "dep:tokio-serde", "tokio-util/codec"] | |||
| flume-transport = ["dep:flume"] | |||
| iroh-net-transport = ["dep:iroh-net", "dep:flume", "dep:quinn", "dep:postcard", "dep:tokio-serde", "tokio-util/codec"] | |||
| iroh-transport = ["dep:iroh-net", "dep:flume", "dep:quinn", "dep:postcard", "dep:tokio-serde", "tokio-util/codec"] | |||
There was a problem hiding this comment.
dep:iroh-net reads odd, but I guess that needs to wait for the next release?
There was a problem hiding this comment.
Yeah, I do the rename now, and then we will have to fix this when the new crates get published.
fogodev
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renamed
The reason for this that while previously iroh was the networking part and a number of canonical protocols, now we changed the naming to make iroh the networking stack and the ability to have custom protocols.
See https://www.iroh.computer/blog/road-to-1-0
Also, I think it also just reads nicer.