feat: Remove MAX_DATA_LIMIT #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to limit the maximum amount of data that can be transferred, both the total size as well as single blob size. There is no real benefit to this, we pass through the reader and do not buffer all this data at once. And avoiding to fill up the user's disk space is not our concern.
|
/cc @dignifiedquire |
rklaehn
approved these changes
Feb 21, 2023
dignifiedquire
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to limit the maximum amount of data that can be transferred,
both the total size as well as single blob size. There is no real
benefit to this, we pass through the reader and do not buffer all this
data at once. And avoiding to fill up the user's disk space is not
our concern.