Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cargo-nextest to run the tests #1867

Merged
merged 28 commits into from
Dec 15, 2023
Merged

Use cargo-nextest to run the tests #1867

merged 28 commits into from
Dec 15, 2023

Conversation

flub
Copy link
Contributor

@flub flub commented Dec 6, 2023

Description

This balances the tests accross multiple cores better and speeds up our test run.

Closes #1864

Notes & open questions

This completes everything suggested in #1864. Runtimes can now be
further improved by getting more runners. Probably 2 more of each
for linux, mac and windows is a good start.

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.

flub added 11 commits December 6, 2023 11:12
Because we use self-hosted runners we do not want the sccache action
to query the github action cache service for each compilation request.
Instead it should be using the local cache.

This means the first time something is compiled on a runner it will
not yet be in the cache, even if another runner already did compile
this.  However because the cache size is set reasonably large over
time all the common dependencies will end up cached on each
self-hosted runner.

Maybe it will be possible to run a self-hosted caching service
sometime, but for now relying on a large local cache is expected to be
reasonable.
let's see where that powershell 7 is...
We had some hosted jobs that might benefit from the cache.  Let's try
enabling them.

Also, netsim is also on a local runner but was trying to use the
hosted cache.
This balances the tests accross multiple cores better and speeds up
our test run.
Base automatically changed from flub/self-hosted-sccache to main December 7, 2023 10:34
@flub
Copy link
Contributor Author

flub commented Dec 15, 2023

Total run time reduced from 1h50 to 1h10 🎉

@flub flub requested a review from Arqu December 15, 2023 14:06
@flub flub marked this pull request as ready for review December 15, 2023 14:06
@flub flub requested a review from dignifiedquire December 15, 2023 14:27
@flub flub enabled auto-merge December 15, 2023 14:35
Copy link
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool

@flub flub added this pull request to the merge queue Dec 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 15, 2023
@flub flub added this pull request to the merge queue Dec 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 15, 2023
@divagant-martian divagant-martian added this pull request to the merge queue Dec 15, 2023
Merged via the queue into main with commit 2fca495 Dec 15, 2023
26 checks passed
@flub flub deleted the flub/ci-nextest branch December 15, 2023 17:00
fubuloubu pushed a commit to ApeWorX/iroh that referenced this pull request Feb 21, 2024
## Description

This balances the tests accross multiple cores better and speeds up our
test run.

Closes n0-computer#1864 

## Notes & open questions

This completes everything suggested in n0-computer#1864.  Runtimes can now be
further improved by getting more runners.  Probably 2 more of each
for linux, mac and windows is a good start.

## Change checklist

- [x] Self-review.
- ~~Documentation updates if relevant.~~
- ~~Tests if relevant.~~
matheus23 pushed a commit that referenced this pull request Nov 14, 2024
## Description

This balances the tests accross multiple cores better and speeds up our
test run.

Closes #1864 

## Notes & open questions

This completes everything suggested in #1864.  Runtimes can now be
further improved by getting more runners.  Probably 2 more of each
for linux, mac and windows is a good start.

## Change checklist

- [x] Self-review.
- ~~Documentation updates if relevant.~~
- ~~Tests if relevant.~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Proposal: Improve CI runtime
3 participants