-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cargo-nextest to run the tests #1867
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we use self-hosted runners we do not want the sccache action to query the github action cache service for each compilation request. Instead it should be using the local cache. This means the first time something is compiled on a runner it will not yet be in the cache, even if another runner already did compile this. However because the cache size is set reasonably large over time all the common dependencies will end up cached on each self-hosted runner. Maybe it will be possible to run a self-hosted caching service sometime, but for now relying on a large local cache is expected to be reasonable.
let's see where that powershell 7 is...
We had some hosted jobs that might benefit from the cache. Let's try enabling them. Also, netsim is also on a local runner but was trying to use the hosted cache.
This balances the tests accross multiple cores better and speeds up our test run.
Total run time reduced from 1h50 to 1h10 🎉 |
dignifiedquire
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very cool
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 15, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 15, 2023
fubuloubu
pushed a commit
to ApeWorX/iroh
that referenced
this pull request
Feb 21, 2024
## Description This balances the tests accross multiple cores better and speeds up our test run. Closes n0-computer#1864 ## Notes & open questions This completes everything suggested in n0-computer#1864. Runtimes can now be further improved by getting more runners. Probably 2 more of each for linux, mac and windows is a good start. ## Change checklist - [x] Self-review. - ~~Documentation updates if relevant.~~ - ~~Tests if relevant.~~
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description This balances the tests accross multiple cores better and speeds up our test run. Closes #1864 ## Notes & open questions This completes everything suggested in #1864. Runtimes can now be further improved by getting more runners. Probably 2 more of each for linux, mac and windows is a good start. ## Change checklist - [x] Self-review. - ~~Documentation updates if relevant.~~ - ~~Tests if relevant.~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This balances the tests accross multiple cores better and speeds up our test run.
Closes #1864
Notes & open questions
This completes everything suggested in #1864. Runtimes can now be
further improved by getting more runners. Probably 2 more of each
for linux, mac and windows is a good start.
Change checklist
Documentation updates if relevant.Tests if relevant.