feat(bytes): switch to a single directory for the flat store #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rklaehn
commented
Nov 30, 2023
| @@ -1173,17 +1173,27 @@ impl Store { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| /// Path to the directory where complete files and outboard files are stored. | |||
| pub(crate) fn complete_path(root: &Path) -> PathBuf { | |||
There was a problem hiding this comment.
These are pub(crate) intentionally since this is an internal detail. This means that some tests have to manually duplicate the code, but I think that is fine.
this does not yet include a migration
rklaehn
force-pushed
the
blob-store-single-dir
branch
from
b3710cd to
25384aa
Compare
Just copy the dirs if they exist and if the v1 dirs don't exist.
this is a positive test. Every single other cli test tests what happens when there is no old version.
dignifiedquire
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Have the constructor for the bao db take a single directory. Internally it will still have 3 directories, although this is not strictly speaking necessary because the files can be distinguished by their extension.
Implements #1662
Notes & open questions
This does not yet include a migration. Do we need one, or do we declare that the number of changes is just too big for this release? It's not super hard to write, but we would then have to drag it around for a while.Added a migration
Change checklist