chore(*): make clippy happy

iroh-net/src/derp/http/client.rs

@@ -1125,8 +1125,6 @@ impl PacketForwarder for Client {
         tokio::spawn(async move {
             // attempt to send the packet 3 times
             for _ in 0..3 {
-                let srckey = srckey;
-                let dstkey = dstkey;
                 let packet = packet.clone();
                 debug!("forward packet");
                 if let Ok((client, _)) = packet_forwarder.connect().await {

iroh-net/src/magicsock.rs

@@ -1366,15 +1366,21 @@ impl Actor {
     async fn send_network(&mut self, transmits: Vec<quinn_udp::Transmit>) {
         trace!(
             "sending:\n{}",
-            transmits
-                .iter()
-                .map(|t| format!(
-                    "  dest: {}, src: {:?}, content_len: {}\n",
-                    QuicMappedAddr(t.destination),
-                    t.src_ip,
-                    t.contents.len()
-                ))
-                .collect::<String>()
+            transmits.iter().fold(
+                String::with_capacity(transmits.len() * 50),
+                |mut final_repr, t| {
+                    final_repr.push_str(
+                        format!(
+                            "  dest: {}, src: {:?}, content_len: {}\n",
+                            QuicMappedAddr(t.destination),
+                            t.src_ip,
+                            t.contents.len()
+                        )
+                        .as_str(),
+                    );
+                    final_repr
+                }
+            )
         );
 
         if transmits.is_empty() {

iroh-net/src/netcheck/reportgen.rs

@@ -859,6 +859,7 @@ async fn run_probe(
 /// return a "204 No Content" response and checking if that's what we get.
 ///
 /// The boolean return is whether we think we have a captive portal.
+#[allow(clippy::unnecessary_unwrap)] // NOTE: clippy's suggestion makes the code a lot more complex
 async fn check_captive_portal(dm: &DerpMap, preferred_derp: Option<u16>) -> Result<bool> {
     // If we have a preferred DERP region with more than one node, try
     // that; otherwise, pick a random one not marked as "Avoid".

iroh-sync/src/sync.rs

@@ -392,7 +392,7 @@ impl From<SignedEntry> for Entry {
 
 impl PartialOrd for SignedEntry {
     fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
-        self.entry.id.partial_cmp(&other.entry.id)
+        Some(self.cmp(other))
     }
 }