Skip to content

Commit

Permalink
fix(ci): better error reporting on netsim fails (#2886)
Browse files Browse the repository at this point in the history
## Description

This bug actually hid some of the netsim failures. The PR fixes that and
gives a link to some logs so you can debug.

## Breaking Changes

<!-- Optional, if there are any breaking changes document them,
including how to migrate older code. -->

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [ ] Self-review.
- [ ] Documentation updates following the [style
guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),
if relevant.
- [ ] Tests if relevant.
- [ ] All breaking changes documented.
  • Loading branch information
Arqu authored Nov 4, 2024
1 parent ef9ae2c commit 8d672f4
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/netsim_runner.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,10 @@ jobs:
overwrite: true

- name: Fail Job if Tests Failed
if: ${{ failure() && steps.run_tests.outcome == 'failure' }}
run: exit 1
if: ${{ steps.run_tests.outcome == 'failure' }}
run: |
echo "Tests failed logs are available at: ${{steps.upload-report.outputs.artifact-url}}"
exit 1
- name: Find Docs Comment
if: ${{ inputs.pr_number != '' }}
Expand Down

0 comments on commit 8d672f4

Please sign in to comment.