Skip to content

Commit

Permalink
refactor: common base library (#1780)
Browse files Browse the repository at this point in the history
## Description

This adds a new crate `iroh_base`. The following types were moved into
the new crate:

* `Hash`, `HashAndFormat` and `BlobFormat` from `iroh_bytes::util`
* `base32` encoding/decoding util functions. They lived at various
places before.
* `RpcError` and `RpcResult` from `iroh_bytes::util`

## Notes & open questions

* Naming: Shall it be `iroh_common` or `iroh_base`? I do not mind. If
anyhow has a preference, please raise. I can change easily.
* Anything else that should be moved over? Anything that I moved that
should *not* be moved?

## Change checklist

- [ ] Self-review.
- [ ] Documentation updates if relevant.
- [ ] Tests if relevant.

---------

Co-authored-by: Asmir Avdicevic <asmir.avdicevic64@gmail.com>
  • Loading branch information
Frando and Arqu authored Nov 8, 2023
1 parent a49b383 commit 1af7dda
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 2 deletions.
26 changes: 24 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
members = [
"iroh",
"iroh-bytes",
"iroh-base",
"iroh-gossip",
"iroh-metrics",
"iroh-net",
Expand Down

0 comments on commit 1af7dda

Please sign in to comment.