chore: Remove eslint-disable comments where no longer needed; feat: A…

…lways fetch the latest article whenever the Article Viewer page is refreshed

README.md

@@ -44,7 +44,8 @@ Welcome to the source code repository for the LCC web app! Here you'll find an o
 v4.1.5 - November 3rd, 2024
 </summary>
 
-- 🚀 Add ability to show/hide sensitive information when logged in as admin wherever personal details may be displayed 
+- 🚀 Add ability to show/hide sensitive information when logged in as admin wherever personal details may be displayed
+- 🐛 Always fetch the latest article whenever the Article Viewer page is refreshed
 
 </details>
 

src/app/services/articles.service.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import { Observable, of } from 'rxjs';
 import { catchError, map, switchMap } from 'rxjs/operators';
 

src/app/services/members.service.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import { Observable, of } from 'rxjs';
 import { catchError, map, switchMap } from 'rxjs/operators';
 

src/app/services/schedule.service.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import { Observable, of } from 'rxjs';
 import { catchError, map, switchMap } from 'rxjs/operators';
 

src/app/store/articles/articles.effects.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import { Actions, createEffect, ofType } from '@ngrx/effects';
 import { concatLatestFrom } from '@ngrx/operators';
 import { Store } from '@ngrx/store';
@@ -9,7 +8,12 @@ import { Injectable } from '@angular/core';
 
 import { ArticlesService, ImagesService, LoaderService } from '@app/services';
 import { AuthSelectors } from '@app/store/auth';
-import type { Article, ModificationInfo, ServiceResponse } from '@app/types';
+import {
+  type Article,
+  ControlModes,
+  type ModificationInfo,
+  type ServiceResponse,
+} from '@app/types';
 import { isDefined } from '@app/utils';
 
 import * as ArticlesActions from './articles.actions';
@@ -175,9 +179,21 @@ export class ArticlesEffects {
     );
   });
 
+  updateArticleInArticleViewer$ = createEffect(() => {
+    return this.actions$.pipe(
+      ofType(ArticlesActions.fetchArticleSucceeded),
+      map(({ article }) =>
+        ArticlesActions.setArticle({
+          article,
+          controlMode: ControlModes.VIEW,
+        }),
+      ),
+    );
+  });
+
   requestImageUrl$ = createEffect(() => {
     return this.actions$.pipe(
-      ofType(ArticlesActions.fetchArticleSucceeded, ArticlesActions.setArticle),
+      ofType(ArticlesActions.setArticle),
       map(({ article }) => article.imageId),
       filter(isDefined),
       map(imageId => ArticlesActions.getArticleImageUrlRequested({ imageId })),

src/app/store/auth/auth.effects.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import { Actions, createEffect, ofType } from '@ngrx/effects';
 import { concatLatestFrom } from '@ngrx/operators';
 import { Store } from '@ngrx/store';

src/app/store/members/members.effects.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import { Actions, createEffect, ofType } from '@ngrx/effects';
 import { concatLatestFrom } from '@ngrx/operators';
 import { Store } from '@ngrx/store';

src/app/store/nav/nav.effects.ts

@@ -52,22 +52,8 @@ export class NavEffects {
       ofType(routerNavigatedAction),
       filter(({ payload }) => payload.event.url.startsWith('/article/view/')),
       map(({ payload }) => {
-        const currentPath = payload.event.url;
-        const articleId = currentPath.split('/article/view/')[1].split('#')[0];
-        return { currentPath, articleId };
-      }),
-      concatLatestFrom(() => this.store.select(NavSelectors.previousPath)),
-      filter(([{ currentPath }, previousPath]) => currentPath !== previousPath),
-      concatLatestFrom(([{ articleId }]) =>
-        this.store.select(ArticlesSelectors.articleById(articleId)),
-      ),
-      map(([[{ articleId }], articleInStore]) => {
-        return articleInStore
-          ? ArticlesActions.setArticle({
-              article: articleInStore,
-              controlMode: ControlModes.VIEW,
-            })
-          : ArticlesActions.fetchArticleRequested({ articleId });
+        const articleId = payload.event.url.split('/article/view/')[1].split('#')[0];
+        return ArticlesActions.fetchArticleRequested({ articleId });
       }),
     ),
   );