Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: allow users to change dotenv file with env var #1040

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

JoaoCostaIFG
Copy link
Contributor

@JoaoCostaIFG JoaoCostaIFG commented Jul 6, 2024

This facilitates the usage of docker secrets for the keys/tokens.

For example on a docker-compose.yml file:

muse:
  image: codetheweb/muse:latest
  container_name: muse
  secrets:
    - muse_env
  environment:
    - ENV_FILE=/run/secrets/muse_env
  restart: unless-stopped
  
secrets:
  muse_env:
    file: /usr/local/etc/muse_env

See relevant dotenv doc

  • I updated the changelog

This facilitates the usage of docker secrets for the keys/tokens.
@JoaoCostaIFG
Copy link
Contributor Author

Not sure if I should update the changelog. Please let me know.

Copy link

github-actions bot commented Jul 6, 2024

📦 A new release has been made for this pull request.

To play around with this PR, pull codetheweb/muse:pr-1040 or codetheweb/muse:3d7a85843fc4c8028ac87a0e5df98c477f2fffc1.

Images are available for x86_64 and ARM64.

Latest commit: 3d7a858

@codetheweb
Copy link
Collaborator

Cool!

  1. Let's default ENV_FILE to /config in the Dockerfile so there's a sensible default.
  2. We should also document this in the README.

Thank you!

@Codixer
Copy link
Contributor

Codixer commented Oct 28, 2024

@JoaoCostaIFG
Do you still want this PR to be processed?

@JoaoCostaIFG
Copy link
Contributor Author

@JoaoCostaIFG Do you still want this PR to be processed?

I haven't been using discord, so I completely forgot about this PR. Sorry about that.
I just pushed the requested changes.
Let me know if there's anything else that needs work.

@codetheweb
Copy link
Collaborator

codetheweb commented Oct 28, 2024

📦 🤖 A new release has been made for this pull request.

To play around with this PR, pull ghcr.io/museofficial/muse:pr-1040.

Images are available for x86_64 and ARM64.

Latest commit: d5cec60

Copy link
Contributor

@Codixer Codixer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See review

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoaoCostaIFG Could you fix the legacy key perchance? See comment/warning by the Actions

Copy link
Contributor Author

@JoaoCostaIFG JoaoCostaIFG Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Codixer
Copy link
Contributor

Codixer commented Oct 29, 2024

LGTM

@Codixer Codixer self-assigned this Oct 29, 2024
@Codixer Codixer changed the base branch from master to develop October 29, 2024 08:15
@Codixer Codixer merged commit f1b4c74 into museofficial:develop Oct 29, 2024
4 checks passed
@Codixer Codixer mentioned this pull request Oct 29, 2024
@codetheweb
Copy link
Collaborator

🚀 Released in Release v2.9.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants