[DataGrid] Free up column header space when icons are not visible #2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanailH
added
component: data grid
DanailH
requested review from
oliviertassinari,
flaviendelangle and
m4theushw
m4theushw
reviewed
Sep 14, 2021
| @@ -123,6 +127,8 @@ export const useStyles = makeStyles( | |||
| }, | |||
| [`& .${gridClasses.iconButtonContainer}`]: { | |||
| display: 'flex', | |||
| visibility: 'hidden', | |||
There was a problem hiding this comment.
Why to change the visibility if we have opacity: 0?
There was a problem hiding this comment.
This is for the container. If I just have the width: 0 there might be cases where something can still be visible.
This opacity is for the items inside.
m4theushw
approved these changes
Sep 20, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this #2460
A small improvement that frees up column header space when column icons are not visible.
You can check Argos for more visual representation 😉
Before:
After:
