Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGridPro] Add test for column pinning with disabled column virtualization #16176

Conversation

cherniavskii
Copy link
Member

Fixes #16136

@cherniavskii cherniavskii added component: data grid This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user regression A bug, but worse feature: Column pinning Related to the data grid Column pinning feature labels Jan 14, 2025
@mui-bot
Copy link

mui-bot commented Jan 14, 2025

Deploy preview: https://deploy-preview-16176--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 8135a6a

@romgrk
Copy link
Contributor

romgrk commented Jan 14, 2025

I haven't read in details, but some of this seems to match the changes here: #15666 (comment), some of that context might be useful.

@cherniavskii
Copy link
Member Author

@romgrk Yes, I considered comments in #15116 (comment)

@cherniavskii cherniavskii added needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Jan 14, 2025
@cherniavskii cherniavskii requested a review from romgrk January 14, 2025 19:37
@cherniavskii cherniavskii marked this pull request as ready for review January 14, 2025 19:37
@lauri865
Copy link
Contributor

I did already fix it in #15666 as well. Maybe we can try to merge it first and then add the regression test? To avoid making the merge conflicts even more difficult.

@cherniavskii
Copy link
Member Author

@lauri865 If #15666 can be cherry-picked to v7 – sure, let's merge it first 👍🏻

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 14, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 15, 2025
@cherniavskii cherniavskii changed the title [DataGridPro] Fix column headers layout when column virtualization is disabled [DataGridPro] Add test for column pinning with disabled column virtualization Jan 15, 2025
@cherniavskii cherniavskii added test and removed regression A bug, but worse labels Jan 15, 2025
@cherniavskii cherniavskii enabled auto-merge (squash) January 15, 2025 14:57
@cherniavskii cherniavskii merged commit 8928232 into mui:master Jan 15, 2025
18 checks passed
@cherniavskii cherniavskii deleted the fix-pinned-rows-with-virtualization-disabled branch January 15, 2025 16:21
Copy link

Cherry-pick PRs will be created targeting branches: v7.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Column pinning Related to the data grid Column pinning feature needs cherry-pick The PR should be cherry-picked to master after merge plan: Pro Impact at least one Pro user test v7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] Pinned columns error when disable column virtualization
4 participants