[DataGrid] Use new selectors #15200
[DataGrid] Use new selectors #15200
Conversation
MBilalShafi
added
core
|
Deploy preview: https://deploy-preview-15200--material-ui-x.netlify.app/ Updated pages: |
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
MBilalShafi
force-pushed
the
update-selectors
branch
from
0f54568 to
44438c0
Compare
github-actions
bot
removed
the
PR: out-of-date
MBilalShafi
changed the title
MBilalShafi
changed the title
| ( | ||
| apiRef: React.MutableRefObject<{ state: State; instanceId: GridCoreApi['instanceId'] }>, | ||
| args?: Args, | ||
| ): Result; | ||
| (state: State, instanceId: GridCoreApi['instanceId']): Result; | ||
| (state: State, args?: Args, instanceId?: GridCoreApi['instanceId']): Result; |
There was a problem hiding this comment.
Instance ID parameter being required feels unnecessary.
- We allow slicing data without passing it, it could be fine if the user is aware of the performance issues a respective selector may cause.
- It doesn't apply to non-memoized selectors.
- Even for the memoized selectors, we warn the users to beware of the possible performance issues and act accordingly.
With #11440 it would even be more relevant as the only officially supported way would be the selector(apiRef). Comments are welcome.
There was a problem hiding this comment.
As long as we do #11440, we can get rid of those for v8.
| cellParams1.api.state, | ||
| cellParams1.api.instanceId, | ||
| ); | ||
| const model = gridRowGroupingSanitizedModelSelector({ current: cellParams1.api }); |
There was a problem hiding this comment.
A step towards #11440
There was a problem hiding this comment.
We're passing api in a few places, we should probably consider replacing those with apiRef.
There was a problem hiding this comment.
I think it couples more with #11440, let's consider it when working on that.
Closes #15478
Todos
Follow-ups:
Changelog
Breaking changes
The selectors signature has been updated due to the support of arguments in the selectors. Pass
undefinedasargumentsif the selector doesn't use any arguments.The
useGridSelectorsignature has been updated due to the introduction of arguments parameter in the selectors. Passundefinedasargumentsif the selector doesn't use any arguments.