-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Autocomplete] Fix adornments misaligned RTL
#45330
base: master
Are you sure you want to change the base?
[material-ui][Autocomplete] Fix adornments misaligned RTL
#45330
Conversation
@DiegoAndai this is for #45193 |
Netlify deploy previewhttps://deploy-preview-45330--material-ui.netlify.app/ @material-ui/core: parsed: +0.07% , gzip: +0.02% Bundle size reportDetails of bundle changes (Toolpad) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @solomonalem, thanks for working on this!
-
On the deploy preview (link), the adornments still look misaligned. Do you know why?
-
May I ask you to add a test for this? It should be included in the regression tests, here's an example for the Button component: /~https://github.com/mui/material-ui/blob/master/test/regressions/fixtures/Button/MultilineButton.js (you will have to create folder for the Chip component)
|
Hey @solomonalem!
You can test this locally by running |
Closes: 45193
Local Demo
createTheme
to create thertl
direction to test it locally