Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix typo on Netlify script #45278

Merged
merged 4 commits into from
Feb 11, 2025
Merged

[core] Fix typo on Netlify script #45278

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e7694c
Update feedback-management.mts
maximevtush Feb 10, 2025
b24935c
Merge branch 'master' into master
maximevtush Feb 10, 2025
3f37834
Merge branch 'master' into master
aarongarciah Feb 11, 2025
051e3de
prettier
aarongarciah Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions netlify/functions/feedback-management.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ app.action<BlockAction<ButtonAction>>('delete_action', async ({ ack, body, clien

const channelId = channel?.id;

const { comment, currentLocationURL = '', commmentSectionURL = '' } = JSON.parse(value);
const { comment, currentLocationURL = '', commentSectionURL = '' } = JSON.parse(value);

const googleAuth = new JWT({
email: 'service-account-804@docs-feedbacks.iam.gserviceaccount.com',
Expand All @@ -121,7 +121,7 @@ app.action<BlockAction<ButtonAction>>('delete_action', async ({ ack, body, clien
range: 'Deleted messages!A:D',
valueInputOption: 'USER_ENTERED',
resource: {
values: [[username, comment, currentLocationURL, commmentSectionURL]],
values: [[username, comment, currentLocationURL, commentSectionURL]],
},
});

Expand Down Expand Up @@ -150,7 +150,7 @@ app.action('save_message', async ({ ack, body, client, logger }) => {
} = body as BlockAction<ButtonAction>;

const channelId = channel?.id;
const { comment, currentLocationURL = '', commmentSectionURL = '' } = JSON.parse(value);
const { comment, currentLocationURL = '', commentSectionURL = '' } = JSON.parse(value);

const googleAuth = new JWT({
email: 'service-account-804@docs-feedbacks.iam.gserviceaccount.com',
Expand All @@ -165,7 +165,7 @@ app.action('save_message', async ({ ack, body, client, logger }) => {
range: 'Sheet1!A:D',
valueInputOption: 'USER_ENTERED',
updates: {
values: [[username, comment, currentLocationURL, commmentSectionURL]],
values: [[username, comment, currentLocationURL, commentSectionURL]],
},
});

Expand Down Expand Up @@ -198,24 +198,22 @@ export const handler: Handler = async (event, context, callback) => {
rating,
comment,
currentLocationURL,
commmentSectionURL: inCommmentSectionURL,
commmentSectionTitle,
commentSectionURL: inCommentSectionURL,
commentSectionTitle,
githubRepo,
productId,
} = data;

// The design feedback alert was removed in /~https://github.com/mui/material-ui/pull/39691
// This dead code is here to simplify the creation of special feedback channel
const isDesignFeedback = inCommmentSectionURL.includes('#new-docs-api-feedback');
const commmentSectionURL = isDesignFeedback ? '' : inCommmentSectionURL;
const isDesignFeedback = inCommentSectionURL.includes('#new-docs-api-feedback');
const commentSectionURL = isDesignFeedback ? '' : inCommentSectionURL;

const simpleSlackMessage = [
`New comment ${rating === 1 ? '👍' : ''}${rating === 0 ? '👎' : ''}`,
`>${comment.split('\n').join('\n>')}`,
`sent from ${currentLocationURL}${
commmentSectionTitle
? ` (from section <${commmentSectionURL}|${commmentSectionTitle})>`
: ''
commentSectionTitle ? ` (from section <${commentSectionURL}|${commentSectionTitle})>` : ''
}`,
].join('\n\n');

Expand All @@ -224,7 +222,7 @@ export const handler: Handler = async (event, context, callback) => {
body: `Feedback received:
${comment}

from ${commmentSectionURL}
from ${commentSectionURL}
`,
});

Expand Down Expand Up @@ -260,7 +258,7 @@ from ${commmentSectionURL}
value: JSON.stringify({
comment,
currentLocationURL,
commmentSectionURL,
commentSectionURL,
}),
action_id: 'save_message',
},
Expand All @@ -273,7 +271,7 @@ from ${commmentSectionURL}
value: JSON.stringify({
comment,
currentLocationURL,
commmentSectionURL,
commentSectionURL,
}),
style: 'danger',
action_id: 'delete_action',
Expand Down