-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ButtonBase] Update focusVisible ponyfill for shadowRoots #13483
Conversation
The focusVisible polyfill for ButtonBase components was not resolving targets inside a shadowRoot. Now the activeElement for nested shadowRoots is resolved to add focus visible classes to targets in the shadow DOM. Closes mui#13447
This is proving slightly painful to test cross-browser without polyfilling the shadow DOM api in the test environments - and I don't want the test to turn into an |
94f4a7f
to
e9f3d36
Compare
@JaiPe The best option is probably to only run the test where the shadow DOM API is available. If it's too much a pain, we can only run it on a simulation server side. /jsdom/.test(window.navigator.userAgent) |
Looking at the build error, I believe you are almost good :). |
e9f3d36
to
73c6084
Compare
73c6084
to
0c1cdfb
Compare
@JaiPe You currently don't have you git client linked to you github account. Your contributions won't be linked to your account. See https://help.github.com/articles/why-are-my-contributions-not-showing-up-on-my-profile/#you-havent-added-your-local-git-commit-email-to-your-profile |
@JaiPe It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
The focusVisible polyfill for ButtonBase components was not resolving
targets inside a shadowRoot. Now the activeElement for nested
shadowRoots is resolved to add focus visible classes to targets in the
shadow DOM.
Closes #13447